duplicate platform kalo ganti project

src/main/kotlin/com/swagger/rest/controllers/PlatformController.kt

@@ -51,18 +51,18 @@ class PlatformController(
             val found = platformRepository.findByName(platform.name, project)!!.size
             val foundProject = projectRepository.findById(project.toLong()).isPresent
             if (platform.name.isNotBlank()) {
-                if (!foundProject) {
+                if (!foundProject) {//project not found
                     ResponseEntity<Platform>(HttpStatus.NOT_FOUND)
-                } else if (platform.name.length > 100) {
+                } else if (platform.name.length > 100) {//too long
                     ResponseEntity<Platform>(HttpStatus.PAYLOAD_TOO_LARGE)
-                } else if (found > 0) {
+                } else if (found > 0) {//duplicate
                     ResponseEntity<Platform>(HttpStatus.CONFLICT)
                 } else {
                     platform.project_id = projectRepository.findById(project.toLong()).get()
                     val savePlatform: Platform = platformRepository.save(platform)
                     ResponseEntity<Platform>(savePlatform, HttpStatus.CREATED)
                 }
-            } else {
+            } else {//invalid name
                 ResponseEntity<Platform>(HttpStatus.BAD_REQUEST)
             }
         } catch (e: Exception) {
@@ -71,34 +71,36 @@ class PlatformController(
     }
 
     @PutMapping("/platforms/{id}")
-    fun updatePlatformById(@PathVariable("id") id: Long, @RequestBody platform: PlatformInput): Any {
-        val platformData: Optional<Platform?> = platformRepository.findById(id)
-        val found = platformRepository.findByName(platform.name, platform.project_id.toString())!!.size
-        val foundProject = projectRepository.findById(platform.project_id!!.toLong())
-        return if (platform.name!!.isNotBlank()) {
-            if (platform.name!!.length > 100) {
+    fun updatePlatformById(@PathVariable("id") id: Long, @RequestBody input: PlatformInput): Any {
+        val targetProject = projectRepository.findById(input.project_id!!.toLong())//target project
+        val platformExist = platformRepository.findById(id)//exist data
+        return if (input.name!!.isNotBlank()) {
+            if (input.name!!.length > 100) {//too long
                 ResponseEntity<Platform>(HttpStatus.PAYLOAD_TOO_LARGE)
-            } else if (foundProject.isEmpty) {
-                println(1)
+            } else if (targetProject.isEmpty || platformExist.isEmpty) {//target project not found
                 ResponseEntity<Platform>(HttpStatus.NOT_FOUND)
-            } else if (platformData.isPresent) {
-                println(2)
-                if (((platform.name == platformData.get().name && found > 0) || (platform.name !== platformData.get().name && found == 0))) {
-                    println(3)
-                    val savePlatform: Platform = platformData.get()
-                    savePlatform.project_id = foundProject.get()
-                    savePlatform.name = platform.name!!
-                    ResponseEntity<Platform>(platformRepository.save(savePlatform), HttpStatus.OK)
+            } else {
+                val savePlatform = platformExist.get()
+                savePlatform.project_id = targetProject.get()
+                savePlatform.name = input.name!!
+                if (input.project_id.toString() !== platformExist.get().project_id.toString()) {
+                    val check = platformRepository.findByName(input.name, input.project_id.toString())
+                    if (check!!.isNotEmpty()) {
+                        ResponseEntity<Platform>(HttpStatus.CONFLICT)
+                    } else {
+                        ResponseEntity<Platform>(platformRepository.save(savePlatform), HttpStatus.OK)
+                    }
+                } else if (input.name !== platformExist.get().name) {
+                    if (targetProject.isEmpty) {
+                        ResponseEntity<Platform>(platformRepository.save(savePlatform), HttpStatus.OK)
+                    } else {
+                        ResponseEntity<Platform>(HttpStatus.CONFLICT)
+                    }
                 } else {
-                    println(4)
                     ResponseEntity<Platform>(HttpStatus.CONFLICT)
                 }
-            } else {
-                println(5)
-                ResponseEntity<Platform>(HttpStatus.NOT_FOUND)
             }
-        } else {
-            println(6)
+        } else {//invalid name
             ResponseEntity<Platform>(HttpStatus.BAD_REQUEST)
         }
     }

src/main/kotlin/com/swagger/rest/controllers/ProjectController.kt

@@ -45,15 +45,15 @@ class ProjectController(
         return try {
             val found = projectRepository.findByNameContaining(project.name)!!.size
             if (project.name.isNotBlank()) {
-                if (project.name.length > 100 || project.description!!.length > 255) {
+                if (project.name.length > 100 || project.description!!.length > 255) {//too long
                     ResponseEntity<Project>(HttpStatus.PAYLOAD_TOO_LARGE)
-                } else if (found > 0) {
+                } else if (found > 0) {//duplicate
                     ResponseEntity<Project>(HttpStatus.CONFLICT)
                 } else {
                     val saveProject: Project = projectRepository.save(project)
                     ResponseEntity<Project>(saveProject, HttpStatus.CREATED)
                 }
-            } else {
+            } else {//name invalid
                 ResponseEntity<Project>(HttpStatus.BAD_REQUEST)
             }
         } catch (e: Exception) {
@@ -63,24 +63,24 @@ class ProjectController(
 
     @PutMapping("/projects/{id}")
     fun updateProjectById(@PathVariable("id") id: Long, @RequestBody project: Project): ResponseEntity<out Any?> {
-        val projectData: Optional<Project?> = projectRepository.findById(id)
+        val projectData = projectRepository.findById(id)
         val found = projectRepository.findByNameContaining(project.name)!!.size
         return if (project.name.isNotBlank()) {
-            if (project.name.length > 100 || project.description!!.length > 255) {
+            if (project.name.length > 100 || project.description!!.length > 255) {//too long
                 ResponseEntity<Project>(HttpStatus.PAYLOAD_TOO_LARGE)
             } else if (projectData.isPresent) {
                 if ((project.name == projectData.get().name && found > 0) || (project.name !== projectData.get().name && found == 0)) {
-                    val saveProject: Project = projectData.get()
+                    val saveProject = projectData.get()
                     saveProject.name = project.name
                     saveProject.description = project.description
                     ResponseEntity<Any?>(projectRepository.save(saveProject), HttpStatus.OK)
-                } else {
+                } else {//duplicate
                     ResponseEntity<Project>(HttpStatus.CONFLICT)
                 }
-            } else {
+            } else {//target invalid
                 ResponseEntity<Project?>(HttpStatus.NOT_FOUND)
             }
-        } else {
+        } else {//name invalid
             ResponseEntity<Project?>(HttpStatus.BAD_REQUEST)
         }
     }
@@ -90,12 +90,12 @@ class ProjectController(
         val find = projectRepository.findById(id)
         val used = platformRepository.findByProject(id.toString())!!.size
         return try {
-            if (used > 0) {
+            if (used > 0) {//child used in transaction
                 ResponseEntity(HttpStatus.RESET_CONTENT)
             } else if (find.isPresent) {
                 projectRepository.deleteById(id)
                 ResponseEntity(HttpStatus.OK)
-            } else {
+            } else {//project not found
                 ResponseEntity(HttpStatus.NOT_FOUND)
             }
         } catch (e: Exception) {

src/main/kotlin/com/swagger/rest/repositories/PlatformRepository.kt

@@ -10,4 +10,6 @@ interface PlatformRepository : JpaRepository<Platform?, Long?> {
 
     @Query("SELECT f.* FROM platform f WHERE project_id=?1", nativeQuery = true)
     fun findByProject(project: String?): List<Platform?>?
+
+    fun findByNameContaining(name: String?): List<Platform>
 }